Commit 2d6b74ba authored by Riccardo Mancini's avatar Riccardo Mancini Committed by Arnaldo Carvalho de Melo
Browse files

perf map: Fix dso->nsinfo refcounting 



ASan reports a memory leak of nsinfo during the execution of

  # perf test "31: Lookup mmap thread"

The leak is caused by a refcounted variable being replaced without
dropping the refcount.

This patch makes sure that the refcnt of nsinfo is decreased whenever a
refcounted variable is replaced with a new value.

Signed-off-by: default avatarRiccardo Mancini <rickyman7@gmail.com>
Fixes: bf2e710b ("perf maps: Lookup maps in both intitial mountns and inner mountns.")
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Krister Johansen <kjlx@templeofstupid.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/55223bc8821b34ccb01f92ef1401c02b6a32e61f.1626343282.git.rickyman7@gmail.com


[ Split from a larger patch ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0967ebff

tools/perf/util/map.c

+2 −0
Original line number Diff line number Diff line
@@ -192,6 +192,8 @@ struct map *map__new(struct machine *machine, u64 start, u64 len, 
			if (!(prot & PROT_EXEC))

				dso__set_loaded(dso);

		}



		nsinfo__put(dso->nsinfo);

		dso->nsinfo = nsi;



		if (build_id__is_defined(bid))