Commit 2d4fcc5a authored by Dan Carpenter's avatar Dan Carpenter Committed by Stephen Boyd
Browse files

clk: versatile: clk-icst: use after free on error path 



This frees "name" and then tries to display in as part of the error
message on the next line.  Swap the order.

Fixes: 1b2189f3 ("clk: versatile: clk-icst: Ensure clock names are unique")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211117072604.GC5237@kili


Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent e53f2086

drivers/clk/versatile/clk-icst.c

+1 −1
Original line number Diff line number Diff line
@@ -543,8 +543,8 @@ static void __init of_syscon_icst_setup(struct device_node *np) 


	regclk = icst_clk_setup(NULL, &icst_desc, name, parent_name, map, ctype);

	if (IS_ERR(regclk)) {

		kfree(name);

		pr_err("error setting up syscon ICST clock %s\n", name);

		kfree(name);

		return;

	}

	of_clk_add_provider(np, of_clk_src_simple_get, regclk);