Commit 2d409a2b authored by Anand Jain's avatar Anand Jain Committed by sanglipeng
Browse files

btrfs: free btrfs_path before copying subvol info to userspace 

stable inclusion
from stable-v5.10.157
commit 1581830c0eca75c5e77bc8671ab8ba9cc2e00de7
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7MU59

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=1581830c0eca75c5e77bc8671ab8ba9cc2e00de7



--------------------------------

commit 013c1c55 upstream.

btrfs_ioctl_get_subvol_info() frees the search path after the userspace
copy from the temp buffer @subvol_info. This can lead to a lock splat
warning.

Fix this by freeing the path before we copy it to userspace.

CC: stable@vger.kernel.org # 4.19+
Signed-off-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 2afdcdd3

fs/btrfs/ioctl.c

+2 −0
Original line number Diff line number Diff line
@@ -2811,6 +2811,8 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp) 
		}

	}



	btrfs_free_path(path);

	path = NULL;

	if (copy_to_user(argp, subvol_info, sizeof(*subvol_info)))

		ret = -EFAULT;