Commit 2d3b6db1 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij
Browse files

gpiolib: acpi: Respect pin bias setting 



For now, we don't take into account the pin bias settings supplied by ACPI.
This change is targeting the mentioned gap.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 606be344

drivers/gpio/gpiolib-acpi.c

+12 −0
Original line number Diff line number Diff line
@@ -528,6 +528,17 @@ acpi_gpio_update_gpiod_flags(enum gpiod_flags *flags, struct acpi_gpio_info *inf 
int acpi_gpio_update_gpiod_lookup_flags(unsigned long *lookupflags,

					struct acpi_gpio_info *info)

{

	switch (info->pin_config) {

	case ACPI_PIN_CONFIG_PULLUP:

		*lookupflags |= GPIO_PULL_UP;

		break;

	case ACPI_PIN_CONFIG_PULLDOWN:

		*lookupflags |= GPIO_PULL_DOWN;

		break;

	default:

		break;

	}



	if (info->polarity == GPIO_ACTIVE_LOW)

		*lookupflags |= GPIO_ACTIVE_LOW;
@@ -567,6 +578,7 @@ static int acpi_populate_gpio_lookup(struct acpi_resource *ares, void *data) 


		lookup->desc = acpi_get_gpiod(agpio->resource_source.string_ptr,

					      agpio->pin_table[pin_index]);

		lookup->info.pin_config = agpio->pin_config;

		lookup->info.gpioint = gpioint;



		/*

drivers/gpio/gpiolib.h

+2 −0
Original line number Diff line number Diff line
@@ -74,6 +74,7 @@ struct gpio_device { 
 * @adev: reference to ACPI device which consumes GPIO resource

 * @flags: GPIO initialization flags

 * @gpioint: if %true this GPIO is of type GpioInt otherwise type is GpioIo

 * @pin_config: pin bias as provided by ACPI

 * @polarity: interrupt polarity as provided by ACPI

 * @triggering: triggering type as provided by ACPI

 * @quirks: Linux specific quirks as provided by struct acpi_gpio_mapping
@@ -82,6 +83,7 @@ struct acpi_gpio_info { 
	struct acpi_device *adev;

	enum gpiod_flags flags;

	bool gpioint;

	int pin_config;

	int polarity;

	int triggering;

	unsigned int quirks;