Commit 2d3960e5 authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

net: phy: marvell: Add software control of the LEDs 



Add a brightness function, so the LEDs can be controlled from
software using the standard Linux LED infrastructure.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 68481818

drivers/net/phy/marvell.c

+40 −5
Original line number Diff line number Diff line
@@ -144,7 +144,9 @@ 
/* WOL Event Interrupt Enable */

#define MII_88E1318S_PHY_CSIER_WOL_EIE			BIT(7)



/* LED Timer Control Register */

#define MII_88E1318S_PHY_LED_FUNC		0x10

#define MII_88E1318S_PHY_LED_FUNC_OFF		(0x8)

#define MII_88E1318S_PHY_LED_FUNC_ON		(0x9)

#define MII_88E1318S_PHY_LED_TCR		0x12

#define MII_88E1318S_PHY_LED_TCR_FORCE_INT	BIT(15)

#define MII_88E1318S_PHY_LED_TCR_INTn_ENABLE	BIT(7)
@@ -2832,6 +2834,34 @@ static int marvell_hwmon_probe(struct phy_device *phydev) 
}

#endif



static int m88e1318_led_brightness_set(struct phy_device *phydev,

				       u8 index, enum led_brightness value)

{

	int reg;



	reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE,

			     MII_88E1318S_PHY_LED_FUNC);

	if (reg < 0)

		return reg;



	switch (index) {

	case 0:

	case 1:

	case 2:

		reg &= ~(0xf << (4 * index));

		if (value == LED_OFF)

			reg |= MII_88E1318S_PHY_LED_FUNC_OFF << (4 * index);

		else

			reg |= MII_88E1318S_PHY_LED_FUNC_ON << (4 * index);

		break;

	default:

		return -EINVAL;

	}



	return phy_write_paged(phydev, MII_MARVELL_LED_PAGE,

			       MII_88E1318S_PHY_LED_FUNC, reg);

}



static int marvell_probe(struct phy_device *phydev)

{

	struct marvell_priv *priv;
@@ -3081,6 +3111,7 @@ static struct phy_driver marvell_drivers[] = { 
		.get_sset_count = marvell_get_sset_count,

		.get_strings = marvell_get_strings,

		.get_stats = marvell_get_stats,

		.led_brightness_set = m88e1318_led_brightness_set,

	},

	{

		.phy_id = MARVELL_PHY_ID_88E1145,
@@ -3187,6 +3218,7 @@ static struct phy_driver marvell_drivers[] = { 
		.cable_test_start = marvell_vct7_cable_test_start,

		.cable_test_tdr_start = marvell_vct5_cable_test_tdr_start,

		.cable_test_get_status = marvell_vct7_cable_test_get_status,

		.led_brightness_set = m88e1318_led_brightness_set,

	},

	{

		.phy_id = MARVELL_PHY_ID_88E1540,
@@ -3213,6 +3245,7 @@ static struct phy_driver marvell_drivers[] = { 
		.cable_test_start = marvell_vct7_cable_test_start,

		.cable_test_tdr_start = marvell_vct5_cable_test_tdr_start,

		.cable_test_get_status = marvell_vct7_cable_test_get_status,

		.led_brightness_set = m88e1318_led_brightness_set,

	},

	{

		.phy_id = MARVELL_PHY_ID_88E1545,
@@ -3239,6 +3272,7 @@ static struct phy_driver marvell_drivers[] = { 
		.cable_test_start = marvell_vct7_cable_test_start,

		.cable_test_tdr_start = marvell_vct5_cable_test_tdr_start,

		.cable_test_get_status = marvell_vct7_cable_test_get_status,

		.led_brightness_set = m88e1318_led_brightness_set,

	},

	{

		.phy_id = MARVELL_PHY_ID_88E3016,
@@ -3380,6 +3414,7 @@ static struct phy_driver marvell_drivers[] = { 
		.get_stats = marvell_get_stats,

		.get_tunable = m88e1540_get_tunable,

		.set_tunable = m88e1540_set_tunable,

		.led_brightness_set = m88e1318_led_brightness_set,

	},

};