Commit 2d2802fb authored by Kai Ye's avatar Kai Ye Committed by Greg Kroah-Hartman
Browse files

uacce: use sysfs_emit instead of sprintf 



Use the sysfs_emit to replace sprintf. sprintf may cause
output defect in sysfs content, it is better to use new
added sysfs_emit function which knows the size of the
temporary buffer.

Signed-off-by: default avatarKai Ye <yekai13@huawei.com>
Link: https://lore.kernel.org/r/20211206104724.11559-1-yekai13@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 909c648e

drivers/misc/uacce/uacce.c

+6 −6
Original line number Diff line number Diff line
@@ -289,7 +289,7 @@ static ssize_t api_show(struct device *dev, 
{

	struct uacce_device *uacce = to_uacce_device(dev);



	return sprintf(buf, "%s\n", uacce->api_ver);

	return sysfs_emit(buf, "%s\n", uacce->api_ver);

}



static ssize_t flags_show(struct device *dev,
@@ -297,7 +297,7 @@ static ssize_t flags_show(struct device *dev, 
{

	struct uacce_device *uacce = to_uacce_device(dev);



	return sprintf(buf, "%u\n", uacce->flags);

	return sysfs_emit(buf, "%u\n", uacce->flags);

}



static ssize_t available_instances_show(struct device *dev,
@@ -309,7 +309,7 @@ static ssize_t available_instances_show(struct device *dev, 
	if (!uacce->ops->get_available_instances)

		return -ENODEV;



	return sprintf(buf, "%d\n",

	return sysfs_emit(buf, "%d\n",

		       uacce->ops->get_available_instances(uacce));

}
@@ -318,7 +318,7 @@ static ssize_t algorithms_show(struct device *dev, 
{

	struct uacce_device *uacce = to_uacce_device(dev);



	return sprintf(buf, "%s\n", uacce->algs);

	return sysfs_emit(buf, "%s\n", uacce->algs);

}



static ssize_t region_mmio_size_show(struct device *dev,
@@ -326,7 +326,7 @@ static ssize_t region_mmio_size_show(struct device *dev, 
{

	struct uacce_device *uacce = to_uacce_device(dev);



	return sprintf(buf, "%lu\n",

	return sysfs_emit(buf, "%lu\n",

		       uacce->qf_pg_num[UACCE_QFRT_MMIO] << PAGE_SHIFT);

}
@@ -335,7 +335,7 @@ static ssize_t region_dus_size_show(struct device *dev, 
{

	struct uacce_device *uacce = to_uacce_device(dev);



	return sprintf(buf, "%lu\n",

	return sysfs_emit(buf, "%lu\n",

		       uacce->qf_pg_num[UACCE_QFRT_DUS] << PAGE_SHIFT);

}