Commit 2d21f733 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by sanglipeng
Browse files

ASoC: codecs: wsa881x: do not set can_multi_write flag 

stable inclusion
from stable-v5.10.184
commit c4aeef56022eb97ad060e14fcede3047e1db772d
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8IRR2

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c4aeef56022eb97ad060e14fcede3047e1db772d



--------------------------------

[ Upstream commit 6e7a6d47 ]

regmap-sdw does not support multi register writes, so there is
no point in setting this flag. This also leads to incorrect
programming of WSA codecs with regmap_multi_reg_write() call.

This invalid configuration should have been rejected by regmap-sdw.

Fixes: a0aab9e1 ("ASoC: codecs: add wsa881x amplifier support")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20230523154605.4284-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 8f713a9d

sound/soc/codecs/wsa881x.c

+0 −1
Original line number Diff line number Diff line
@@ -646,7 +646,6 @@ static struct regmap_config wsa881x_regmap_config = { 
	.readable_reg = wsa881x_readable_register,

	.reg_format_endian = REGMAP_ENDIAN_NATIVE,

	.val_format_endian = REGMAP_ENDIAN_NATIVE,

	.can_multi_write = true,

};



enum {