Commit 2d1a83a4 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Wolfram Sang
Browse files

i2c: cadence: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 9dbba3f8

drivers/i2c/busses/i2c-cadence.c

+4 −5
Original line number Diff line number Diff line
@@ -1251,11 +1251,10 @@ static int cdns_i2c_probe(struct platform_device *pdev) 
		 "Cadence I2C at %08lx", (unsigned long)r_mem->start);



	id->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(id->clk)) {

		if (PTR_ERR(id->clk) != -EPROBE_DEFER)

			dev_err(&pdev->dev, "input clock not found.\n");

		return PTR_ERR(id->clk);

	}

	if (IS_ERR(id->clk))

		return dev_err_probe(&pdev->dev, PTR_ERR(id->clk),

				     "input clock not found.\n");



	ret = clk_prepare_enable(id->clk);

	if (ret)

		dev_err(&pdev->dev, "Unable to enable clock.\n");