Commit 2d085ee1 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Jason Gunthorpe
Browse files

IB/hfi1: Remove redundant variable rcd 

The variable rcd is being assigned a value from a calculation however the
variable is never read, so this redundant variable can be removed.

Cleans up the following clang-analyzer warning:

drivers/infiniband/hw/hfi1/affinity.c:986:3: warning: Value stored to
'rcd' is never read [clang-analyzer-deadcode.DeadStores].

Link: https://lore.kernel.org/r/1619346696-46300-1-git-send-email-jiapeng.chong@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent c6c11ad3

drivers/infiniband/hw/hfi1/affinity.c

+4 −4
Original line number Diff line number Diff line
@@ -973,7 +973,6 @@ void hfi1_put_irq_affinity(struct hfi1_devdata *dd, 
			   struct hfi1_msix_entry *msix)

{

	struct cpu_mask_set *set = NULL;

	struct hfi1_ctxtdata *rcd;

	struct hfi1_affinity_node *entry;



	mutex_lock(&node_affinity.lock);
@@ -987,14 +986,15 @@ void hfi1_put_irq_affinity(struct hfi1_devdata *dd, 
	case IRQ_GENERAL:

		/* Don't do accounting for general contexts */

		break;

	case IRQ_RCVCTXT:

		rcd = (struct hfi1_ctxtdata *)msix->arg;

	case IRQ_RCVCTXT: {

		struct hfi1_ctxtdata *rcd = msix->arg;



		/* Don't do accounting for control contexts */

		if (rcd->ctxt != HFI1_CTRL_CTXT)

			set = &entry->rcv_intr;

		break;

	}

	case IRQ_NETDEVCTXT:

		rcd = (struct hfi1_ctxtdata *)msix->arg;

		set = &entry->def_intr;

		break;

	default: