Commit 2cf15021 authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: mvebu: Do not modify PCI IO type bits in conf_write 

PCI IO type bits are already initialized in mvebu_pci_bridge_emul_init()
function and only when IO support is enabled. These type bits are read-only
and pci-bridge-emul.c code already does not allow to modify them from upper
layers.

When IO support is disabled then all IO registers should be read-only and
return zeros. Therefore do not modify PCI IO type bits in
mvebu_pci_bridge_emul_base_conf_write() callback.

Link: https://lore.kernel.org/r/20211125124605.25915-8-pali@kernel.org


Fixes: 1f08673e ("PCI: mvebu: Convert to PCI emulated bridge config space")
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent e42b8558

drivers/pci/controller/pci-mvebu.c

+0 −7
Original line number Diff line number Diff line
@@ -511,13 +511,6 @@ mvebu_pci_bridge_emul_base_conf_write(struct pci_bridge_emul *bridge, 
		break;



	case PCI_IO_BASE:

		/*

		 * We keep bit 1 set, it is a read-only bit that

		 * indicates we support 32 bits addressing for the

		 * I/O

		 */

		conf->iobase |= PCI_IO_RANGE_TYPE_32;

		conf->iolimit |= PCI_IO_RANGE_TYPE_32;

		mvebu_pcie_handle_iobase_change(port);

		break;