Unverified Commit 2ce949a8 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!6008 locking/osq_lock: Avoid false sharing in optimistic_spin_node 

Merge Pull Request from: @ci-robot 
 
PR sync from: liwei <liwei728@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/SRJVDOSVE5JSCQM4VWKH6V2OXMIHKSUZ/ 
 
https://gitee.com/openeuler/kernel/issues/I8MV01 
 
Link:https://gitee.com/openeuler/kernel/pulls/6008

 

Reviewed-by: default avatarWei Li <liwei391@huawei.com>
Reviewed-by: default avatarZucheng Zheng <zhengzucheng@huawei.com>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parents 7c7ad035 7b4348ab

include/linux/osq_lock.h

+1 −1
Original line number Diff line number Diff line
@@ -9,7 +9,7 @@ 
struct optimistic_spin_node {

	struct optimistic_spin_node *next, *prev;

	int locked; /* 1 if lock acquired */

	int cpu; /* encoded CPU # + 1 value */

	int cpu ____cacheline_aligned; /* encoded CPU # + 1 value */

};



struct optimistic_spin_queue {

kernel/locking/osq_lock.c

+7 −1
Original line number Diff line number Diff line
@@ -96,6 +96,12 @@ bool osq_lock(struct optimistic_spin_queue *lock) 


	node->locked = 0;

	node->next = NULL;

	/*

	 * After this cpu member is initialized for the first time, it

	 * would no longer change in fact. That could avoid cache misses

	 * when spin and access the cpu member by other CPUs.

	 */

	if (node->cpu != curr)

		node->cpu = curr;



	/*