Commit 2ce4fd5a authored by Colin Ian King's avatar Colin Ian King Committed by Marc Kleine-Budde
Browse files

can: etas_es58x: Fix missing null check on netdev pointer 

There is an assignment to *netdev that is that can potentially be null
but the null check is checking netdev and not *netdev as intended. Fix
this by adding in the missing * operator.

Fixes: 85372578 ("can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces")
Link: https://lore.kernel.org/r/20210415084723.1807935-1-colin.king@canonical.com


Addresses-Coverity: ("Dereference before null check")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent b2f0ca00

drivers/net/can/usb/etas_es58x/es58x_core.h

+1 −1
Original line number Diff line number Diff line
@@ -625,7 +625,7 @@ static inline int es58x_get_netdev(struct es58x_device *es58x_dev, 
		return -ECHRNG;



	*netdev = es58x_dev->netdev[channel_idx];

	if (!netdev || !netif_device_present(*netdev))

	if (!*netdev || !netif_device_present(*netdev))

		return -ENODEV;



	return 0;