Commit 2cc6a528 authored Dec 07, 2022 by Zheng Yejian Committed by Steven Rostedt (Google) Dec 10, 2022

tracing/hist: Fix wrong return value in parse_action_params()

When number of synth fields is more than SYNTH_FIELDS_MAX,
parse_action_params() should return -EINVAL.

Link: https://lore.kernel.org/linux-trace-kernel/20221207034635.2253990-1-zhengyejian1@huawei.com



Cc: <mhiramat@kernel.org>
Cc: <zanussi@kernel.org>
Cc: stable@vger.kernel.org
Fixes: c282a386 ("tracing: Add 'onmatch' hist trigger action support")
Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

parent 20fb6c99

kernel/trace/trace_events_hist.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -3609,6 +3609,7 @@ static int parse_action_params(struct trace_array tr, char params,
	while (params) {		while (params) {
	if (data->n_params >= SYNTH_FIELDS_MAX) {		if (data->n_params >= SYNTH_FIELDS_MAX) {
	hist_err(tr, HIST_ERR_TOO_MANY_PARAMS, 0);		hist_err(tr, HIST_ERR_TOO_MANY_PARAMS, 0);
			ret = -EINVAL;
	goto out;		goto out;
	}		}