Commit 2cad5d2e authored by Wong Vee Khee's avatar Wong Vee Khee Committed by Jakub Kicinski
Browse files

net: pcs: xpcs: fix error handling on failed to allocate memory 



Drivers such as sja1105 and stmmac that call xpcs_create() expects an
error returned by the pcs-xpcs module, but this was not the case on
failed to allocate memory.

Fixed this by returning an -ENOMEM instead of a NULL pointer.

Fixes: 3ad1d171 ("net: dsa: sja1105: migrate to xpcs for SGMII")
Signed-off-by: default avatarWong Vee Khee <vee.khee.wong@linux.intel.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20210810085812.1808466-1-vee.khee.wong@linux.intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6922110d

drivers/net/pcs/pcs-xpcs.c

+1 −1
Original line number Diff line number Diff line
@@ -1089,7 +1089,7 @@ struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev, 


	xpcs = kzalloc(sizeof(*xpcs), GFP_KERNEL);

	if (!xpcs)

		return NULL;

		return ERR_PTR(-ENOMEM);



	xpcs->mdiodev = mdiodev;