Commit 2ca5e908 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

s390/pci: Rework MSI descriptor walk 



Replace the about to vanish iterators and make use of the filtering.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarNiklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Acked-by: default avatarNiklas Schnelle <schnelle@linux.ibm.com>
Link: https://lore.kernel.org/r/20211206210748.305656158@linutronix.de
parent 3d31bbd3

arch/s390/pci/pci_irq.c

+2 −4
Original line number Diff line number Diff line
@@ -303,7 +303,7 @@ int arch_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type) 


	/* Request MSI interrupts */

	hwirq = bit;

	for_each_pci_msi_entry(msi, pdev) {

	msi_for_each_desc(msi, &pdev->dev, MSI_DESC_NOTASSOCIATED) {

		rc = -EIO;

		if (hwirq - bit >= msi_vecs)

			break;
@@ -362,9 +362,7 @@ void arch_teardown_msi_irqs(struct pci_dev *pdev) 
		return;



	/* Release MSI interrupts */

	for_each_pci_msi_entry(msi, pdev) {

		if (!msi->irq)

			continue;

	msi_for_each_desc(msi, &pdev->dev, MSI_DESC_ASSOCIATED) {

		irq_set_msi_desc(msi->irq, NULL);

		irq_free_desc(msi->irq);

		msi->msg.address_lo = 0;