Commit 2c9d8e01 authored Jul 21, 2020 by Taehee Yoo Committed by David S. Miller Jul 21, 2020

netdevsim: fix unbalaced locking in nsim_create()



In the nsim_create(), rtnl_lock() is called before nsim_bpf_init().
If nsim_bpf_init() is failed, rtnl_unlock() should be called,
but it isn't called.
So, unbalanced locking would occur.

Fixes: e05b2d14 ("netdevsim: move netdev creation/destruction to dev probe")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3506b2f4

drivers/net/netdevsim/netdev.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -302,7 +302,7 @@ nsim_create(struct nsim_dev nsim_dev, struct nsim_dev_port nsim_dev_port)
		rtnl_lock();
		err = nsim_bpf_init(ns);
		if (err)
		goto err_free_netdev;
		goto err_rtnl_unlock;

		nsim_ipsec_init(ns);

		@@ -316,8 +316,8 @@ nsim_create(struct nsim_dev nsim_dev, struct nsim_dev_port nsim_dev_port)
		err_ipsec_teardown:
		nsim_ipsec_teardown(ns);
		nsim_bpf_uninit(ns);
		err_rtnl_unlock:
		rtnl_unlock();
		err_free_netdev:
		free_netdev(dev);
		return ERR_PTR(err);
		}