Commit 2c9a11af authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Improve aux_output not supported error 



For example:

 Before:
   $ perf record -e '{intel_pt/branch=0/,branch-loads/aux-output/ppp}' -- ls -l
   Error:
   branch-loads: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'

 After:
   $ perf record -e '{intel_pt/branch=0/,branch-loads/aux-output/ppp}' -- ls -l
   Error:
   branch-loads: PMU Hardware doesn't support 'aux_output' feature

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Reviewed-by: default avatarAndi Kleen <ak@linux.intel.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lore.kernel.org/lkml/20200710151104.15137-4-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent a58a057c

tools/perf/util/evsel.c

+4 −0
Original line number Diff line number Diff line
@@ -2535,6 +2535,10 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target, 
	 "No such device - did you specify an out-of-range profile CPU?");

		break;

	case EOPNOTSUPP:

		if (evsel->core.attr.aux_output)

			return scnprintf(msg, size,

	"%s: PMU Hardware doesn't support 'aux_output' feature",

					 evsel__name(evsel));

		if (evsel->core.attr.sample_period != 0)

			return scnprintf(msg, size,

	"%s: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'",