Commit 2c8a81dc authored by Tong Tiangen's avatar Tong Tiangen Committed by Andrew Morton
Browse files

riscv/mm: fix two page table check related issues 

Two page table check related issues have been fixed here.

1. Open CONFIG_PAGE_TABLE_CHECK in riscv32, we got a compile error[1]:

   error: implicit declaration of function 'pud_leaf'

   Add pud_leaf() definition to incluce/asm-generic/pgtable-nopmd.h to fix
   this issue.

2. Keep consistent with other pud_xxx() helpers, move pud_user() to
   pgtable-64.h and add pud_user() to pgtable-nopmd.h.

[1]https://lore.kernel.org/linux-mm/202205161811.2nLxmN2O-lkp@intel.com/T/

Link: https://lkml.kernel.org/r/20220517074548.2227779-2-tongtiangen@huawei.com


Fixes: 856eed79f8d3 ("riscv/mm: enable ARCH_SUPPORTS_PAGE_TABLE_CHECK")
Signed-off-by: default avatarTong Tiangen <tongtiangen@huawei.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Guohanjun <guohanjun@huawei.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Will Deacon <will@kernel.org>
Cc: Xie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent bbe832b9

arch/riscv/include/asm/pgtable-64.h

+5 −0
Original line number Diff line number Diff line
@@ -86,6 +86,11 @@ static inline int pud_leaf(pud_t pud) 
	return pud_present(pud) && (pud_val(pud) & _PAGE_LEAF);

}



static inline int pud_user(pud_t pud)

{

	return pud_val(pud) & _PAGE_USER;

}



static inline void set_pud(pud_t *pudp, pud_t pud)

{

	*pudp = pud;

arch/riscv/include/asm/pgtable.h

+0 −5
Original line number Diff line number Diff line
@@ -634,11 +634,6 @@ static inline void set_pmd_at(struct mm_struct *mm, unsigned long addr, 
	return __set_pte_at(mm, addr, (pte_t *)pmdp, pmd_pte(pmd));

}



static inline int pud_user(pud_t pud)

{

	return pte_user(pud_pte(pud));

}



static inline void set_pud_at(struct mm_struct *mm, unsigned long addr,

				pud_t *pudp, pud_t pud)

{

include/asm-generic/pgtable-nopmd.h

+2 −0
Original line number Diff line number Diff line
@@ -30,6 +30,8 @@ typedef struct { pud_t pud; } pmd_t; 
static inline int pud_none(pud_t pud)		{ return 0; }

static inline int pud_bad(pud_t pud)		{ return 0; }

static inline int pud_present(pud_t pud)	{ return 1; }

static inline int pud_user(pud_t pud)		{ return 0; }

static inline int pud_leaf(pud_t pud)		{ return 0; }

static inline void pud_clear(pud_t *pud)	{ }

#define pmd_ERROR(pmd)				(pud_ERROR((pmd).pud))