Commit 2c7bc10d authored Jan 04, 2023 by Jakub Kicinski

netlink: add macro for checking dump ctx size



We encourage casting struct netlink_callback::ctx to a local
struct (in a comment above the field). Provide a convenience
macro for checking if the local struct fits into the ctx.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 623cd13b

include/linux/netlink.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -263,6 +263,10 @@ struct netlink_callback {
		};
		};

		#define NL_ASSET_DUMP_CTX_FITS(type_name) \
		BUILD_BUG_ON(sizeof(type_name) > \
		sizeof_field(struct netlink_callback, ctx))

		struct netlink_notify {
		struct net *net;
		u32 portid;

net/netfilter/nf_conntrack_netlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3866,7 +3866,7 @@ static int __init ctnetlink_init(void)
		{
		int ret;

		BUILD_BUG_ON(sizeof(struct ctnetlink_list_dump_ctx) > sizeof_field(struct netlink_callback, ctx));
		NL_ASSET_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);

		ret = nfnetlink_subsys_register(&ctnl_subsys);
		if (ret < 0) {