Commit 2c642c48 authored by Alex Elder's avatar Alex Elder Committed by Jakub Kicinski
Browse files

net: ipa: change a warning to debug 



When we determine from hardware what the size of IPA memory is
we compare it against what we learned about it from DT.

If DT defines a region that's larger than actual memory, we use the
smaller actual size and issue a warning.

If DT defines a smaller region than actual memory we issue a warning
too.  But in this case the difference is harmless; so rather than
issuing a warning, just provide a debug message instead.

Reorder these checks so the one that matters more is done first.

Reported-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 49e3aeeb

drivers/net/ipa/ipa_mem.c

+4 −4
Original line number Diff line number Diff line
@@ -160,13 +160,13 @@ int ipa_mem_config(struct ipa *ipa) 
	mem_size = 8 * u32_get_bits(val, SHARED_MEM_SIZE_FMASK);



	/* If the sizes don't match, issue a warning */

	if (ipa->mem_offset + mem_size > ipa->mem_size) {

		dev_warn(dev, "ignoring larger reported memory size: 0x%08x\n",

			mem_size);

	} else if (ipa->mem_offset + mem_size < ipa->mem_size) {

	if (ipa->mem_offset + mem_size < ipa->mem_size) {

		dev_warn(dev, "limiting IPA memory size to 0x%08x\n",

			 mem_size);

		ipa->mem_size = mem_size;

	} else if (ipa->mem_offset + mem_size > ipa->mem_size) {

		dev_dbg(dev, "ignoring larger reported memory size: 0x%08x\n",

			mem_size);

	}



	/* Prealloc DMA memory for zeroing regions */