Unverified Commit 2c53debb authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: hsw_rt5640: Update file comments 



Drop redundant and update valuable comments within the file to increase
readability. This patch also revisits module information and kconfig
help strings.

Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Tested-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220620101402.2684366-6-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5b66dde4

sound/soc/intel/boards/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -41,7 +41,7 @@ config SND_SOC_INTEL_SOF_CIRRUS_COMMON 
if SND_SOC_INTEL_CATPT



config SND_SOC_INTEL_HASWELL_MACH

	tristate "Haswell Lynxpoint"

	tristate "Haswell with RT5640 I2S codec"

	depends on I2C

	depends on I2C_DESIGNWARE_PLATFORM || COMPILE_TEST

	depends on X86_INTEL_LPSS || COMPILE_TEST

sound/soc/intel/boards/hsw_rt5640.c

+6 −10
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Intel Haswell Lynxpoint SST Audio

 * Sound card driver for Intel Haswell Lynx Point with Realtek 5640

 *

 * Copyright (C) 2013, Intel Corporation. All rights reserved.

 */
@@ -14,7 +14,6 @@ 
#include <sound/soc-acpi.h>

#include "../../codecs/rt5640.h"



/* Haswell ULT platforms have a Headphone and Mic jack */

static const struct snd_soc_dapm_widget card_widgets[] = {

	SND_SOC_DAPM_HP("Headphones", NULL),

	SND_SOC_DAPM_MIC("Mic", NULL),
@@ -36,10 +35,10 @@ static int codec_link_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, 
	struct snd_interval *channels = hw_param_interval(params, SNDRV_PCM_HW_PARAM_CHANNELS);

	struct snd_interval *rate = hw_param_interval(params, SNDRV_PCM_HW_PARAM_RATE);



	/* The ADSP will covert the FE rate to 48k, stereo */

	/* The ADSP will convert the FE rate to 48k, stereo. */

	rate->min = rate->max = 48000;

	channels->min = channels->max = 2;

	/* set SSP0 to 16 bit */

	/* Set SSP0 to 16 bit. */

	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);



	return 0;
@@ -58,7 +57,7 @@ static int codec_link_hw_params(struct snd_pcm_substream *substream, 
		return ret;

	}



	/* set correct codec filter for DAI format and clock config */

	/* Set correct codec filter for DAI format and clock config. */

	snd_soc_component_update_bits(codec_dai->component, 0x83, 0xffff, 0x8000);



	return ret;
@@ -133,7 +132,6 @@ static struct snd_soc_dai_link card_dai_links[] = { 
	},

};



/* audio machine driver for Haswell Lynxpoint DSP + RT5640 */

static struct snd_soc_card hsw_rt5640_card = {

	.name = "haswell-rt5640",

	.owner = THIS_MODULE,
@@ -152,7 +150,6 @@ static int hsw_rt5640_probe(struct platform_device *pdev) 
	int ret;



	hsw_rt5640_card.dev = &pdev->dev;

	/* override platform name, if required */

	mach = pdev->dev.platform_data;



	ret = snd_soc_fixup_dai_links_platform_name(&hsw_rt5640_card, mach->mach_params.platform);
@@ -172,8 +169,7 @@ static struct platform_driver hsw_rt5640_driver = { 


module_platform_driver(hsw_rt5640_driver)



/* Module information */

MODULE_AUTHOR("Liam Girdwood, Xingchao Wang");

MODULE_DESCRIPTION("Intel SST Audio for Haswell Lynxpoint");

MODULE_LICENSE("GPL v2");

MODULE_DESCRIPTION("Sound card driver for Intel Haswell Lynx Point with Realtek 5640");

MODULE_LICENSE("GPL");

MODULE_ALIAS("platform:hsw_rt5640");