Commit 2c4950ea authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

mlxsw: spectrum_flow: Convert a goto to a return 



No clean-up is performed at the target label of this goto. Convert it to a
direct return.

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2bafb216

drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c

+1 −3
Original line number Diff line number Diff line
@@ -219,8 +219,7 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port, 
					       mlxsw_sp_tc_block_release);

		if (IS_ERR(block_cb)) {

			mlxsw_sp_flow_block_destroy(flow_block);

			err = PTR_ERR(block_cb);

			goto err_cb_register;

			return PTR_ERR(block_cb);

		}

		register_block = true;

	} else {
@@ -247,7 +246,6 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port, 
err_block_bind:

	if (!flow_block_cb_decref(block_cb))

		flow_block_cb_free(block_cb);

err_cb_register:

	return err;

}