Commit 2c48c2f7 authored Jul 19, 2021 by Jiapeng Chong Committed by Yang Yingliang Jul 19, 2021

rtnetlink: Fix missing error code in rtnl_bridge_notify()



stable inclusion
from linux-4.19.196
commit 7e0147403ebae2fc60b1657114058d20e874a89a

--------------------------------

[ Upstream commit a8db57c1 ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'err'.

Eliminate the follow smatch warning:

net/core/rtnetlink.c:4834 rtnl_bridge_notify() warn: missing error code
'err'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

parent c72955f7

net/core/rtnetlink.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -4102,8 +4102,10 @@ static int rtnl_bridge_notify(struct net_device *dev)
		if (err < 0)
		goto errout;

		if (!skb->len)
		if (!skb->len) {
		err = -EINVAL;
		goto errout;
		}

		rtnl_notify(skb, net, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
		return 0;