Commit 2c477ff3 authored by Deepak R Varma's avatar Deepak R Varma Committed by Rob Clark
Browse files

drm: msm: adreno: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe() 

Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe()
function in place of the debugfs_create_file() function will make the
file operation struct "reset" aware of the file's lifetime. Additional
details here: https://lists.archive.carbon60.com/linux/kernel/2369498



Issue reported by Coccinelle script:
scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: default avatarDeepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/9ca2c2e4cbd9ebb282b90f742305fd9b481aacc2.1603998014.git.mh12gx2825@gmail.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent f8f57a38

drivers/gpu/drm/msm/adreno/a5xx_debugfs.c

+3 −3
Original line number Diff line number Diff line
@@ -138,7 +138,7 @@ reset_set(void *data, u64 val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n");

DEFINE_DEBUGFS_ATTRIBUTE(reset_fops, NULL, reset_set, "%llx\n");





void a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor)
@@ -154,6 +154,6 @@ void a5xx_debugfs_init(struct msm_gpu *gpu, struct drm_minor *minor) 
				 ARRAY_SIZE(a5xx_debugfs_list),

				 minor->debugfs_root, minor);



	debugfs_create_file("reset", S_IWUGO, minor->debugfs_root, dev,

	debugfs_create_file_unsafe("reset", S_IWUGO, minor->debugfs_root, dev,

				&reset_fops);

}