Commit 2c34bb6d authored by Wolfram Sang's avatar Wolfram Sang Committed by Leon Romanovsky
Browse files

IB: move from strlcpy with unused retval to strscpy 

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Link: https://lore.kernel.org/r/20220818210018.6841-1-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent dc13fbf7

drivers/infiniband/core/cma_configfs.c

+1 −1
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ static struct config_group *make_cma_dev(struct config_group *group, 
		goto fail;

	}



	strlcpy(cma_dev_group->name, name, sizeof(cma_dev_group->name));

	strscpy(cma_dev_group->name, name, sizeof(cma_dev_group->name));



	config_group_init_type_name(&cma_dev_group->ports_group, "ports",

				    &cma_ports_group_type);

drivers/infiniband/core/device.c

+2 −2
Original line number Diff line number Diff line
@@ -422,7 +422,7 @@ int ib_device_rename(struct ib_device *ibdev, const char *name) 
		return ret;

	}



	strlcpy(ibdev->name, name, IB_DEVICE_NAME_MAX);

	strscpy(ibdev->name, name, IB_DEVICE_NAME_MAX);

	ret = rename_compat_devs(ibdev);



	downgrade_write(&devices_rwsem);
@@ -1217,7 +1217,7 @@ static int assign_name(struct ib_device *device, const char *name) 
		ret = -ENFILE;

		goto out;

	}

	strlcpy(device->name, dev_name(&device->dev), IB_DEVICE_NAME_MAX);

	strscpy(device->name, dev_name(&device->dev), IB_DEVICE_NAME_MAX);



	ret = xa_alloc_cyclic(&devices, &device->index, device, xa_limit_31b,

			&last_id, GFP_KERNEL);

drivers/infiniband/hw/bnxt_re/main.c

+1 −1
Original line number Diff line number Diff line
@@ -725,7 +725,7 @@ static int bnxt_re_register_ib(struct bnxt_re_dev *rdev) 


	/* ib device init */

	ibdev->node_type = RDMA_NODE_IB_CA;

	strlcpy(ibdev->node_desc, BNXT_RE_DESC " HCA",

	strscpy(ibdev->node_desc, BNXT_RE_DESC " HCA",

		strlen(BNXT_RE_DESC) + 5);

	ibdev->phys_port_cnt = 1;

drivers/infiniband/hw/hfi1/file_ops.c

+1 −1
Original line number Diff line number Diff line
@@ -965,7 +965,7 @@ static int allocate_ctxt(struct hfi1_filedata *fd, struct hfi1_devdata *dd, 
	uctxt->userversion = uinfo->userversion;

	uctxt->flags = hfi1_cap_mask; /* save current flag state */

	init_waitqueue_head(&uctxt->wait);

	strlcpy(uctxt->comm, current->comm, sizeof(uctxt->comm));

	strscpy(uctxt->comm, current->comm, sizeof(uctxt->comm));

	memcpy(uctxt->uuid, uinfo->uuid, sizeof(uctxt->uuid));

	uctxt->jkey = generate_jkey(current_uid());

	hfi1_stats.sps_ctxts++;

drivers/infiniband/hw/hfi1/verbs.c

+1 −1
Original line number Diff line number Diff line
@@ -1801,7 +1801,7 @@ int hfi1_register_ib_device(struct hfi1_devdata *dd) 


	ib_set_device_ops(ibdev, &hfi1_dev_ops);



	strlcpy(ibdev->node_desc, init_utsname()->nodename,

	strscpy(ibdev->node_desc, init_utsname()->nodename,

		sizeof(ibdev->node_desc));



	/*