Commit 2c0f0f36 authored by Jon Mediero's avatar Jon Mediero Committed by Jessica Yu
Browse files

module: correctly exit module_kallsyms_on_each_symbol when fn() != 0 



Commit 013c1667 ("kallsyms: refactor
{,module_}kallsyms_on_each_symbol") replaced the return inside the
nested loop with a break, changing the semantics of the function: the
break only exits the innermost loop, so the code continues iterating the
symbols of the next module instead of exiting.

Fixes: 013c1667 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Reviewed-by: default avatarMiroslav Benes <mbenes@suse.cz>
Signed-off-by: default avatarJon Mediero <jmdr@disroot.org>
Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
parent 02b2fb45

kernel/module.c

+2 −1
Original line number Diff line number Diff line
@@ -4415,9 +4415,10 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, 
			ret = fn(data, kallsyms_symbol_name(kallsyms, i),

				 mod, kallsyms_symbol_value(sym));

			if (ret != 0)

				break;

				goto out;

		}

	}

out:

	mutex_unlock(&module_mutex);

	return ret;

}