Commit 2c09bdaa authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Greg Kroah-Hartman
Browse files

usb: mtu3: remove repeated setting of speed 



mtu3_gadget_start() will set speed, no need set it again in
mtu3_gadget_set_speed(), just save the desired speed.

Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1622182260-23767-2-git-send-email-chunfeng.yun@mediatek.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32ab701d

drivers/usb/mtu3/mtu3.h

+0 −1
Original line number Diff line number Diff line
@@ -425,7 +425,6 @@ void mtu3_ep_stall_set(struct mtu3_ep *mep, bool set); 
void mtu3_start(struct mtu3 *mtu);

void mtu3_stop(struct mtu3 *mtu);

void mtu3_dev_on_off(struct mtu3 *mtu, int is_on);

void mtu3_set_speed(struct mtu3 *mtu, enum usb_device_speed speed);



int mtu3_gadget_setup(struct mtu3 *mtu);

void mtu3_gadget_cleanup(struct mtu3 *mtu);

drivers/usb/mtu3/mtu3_core.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ static void mtu3_intr_enable(struct mtu3 *mtu) 
	mtu3_writel(mbase, U3D_DEV_LINK_INTR_ENABLE, SSUSB_DEV_SPEED_CHG_INTR);

}



void mtu3_set_speed(struct mtu3 *mtu, enum usb_device_speed speed)

static void mtu3_set_speed(struct mtu3 *mtu, enum usb_device_speed speed)

{

	void __iomem *mbase = mtu->mac_base;

drivers/usb/mtu3/mtu3_gadget.c

+1 −1
Original line number Diff line number Diff line
@@ -577,7 +577,7 @@ mtu3_gadget_set_speed(struct usb_gadget *g, enum usb_device_speed speed) 
	dev_dbg(mtu->dev, "%s %s\n", __func__, usb_speed_string(speed));



	spin_lock_irqsave(&mtu->lock, flags);

	mtu3_set_speed(mtu, speed);

	mtu->speed = speed;

	spin_unlock_irqrestore(&mtu->lock, flags);

}