Commit 2bddad9e authored by Justin Chen's avatar Justin Chen Committed by Jakub Kicinski
Browse files

ethtool: ioctl: account for sopass diff in set_wol 



sopass won't be set if wolopt doesn't change. This means the following
will fail to set the correct sopass.
ethtool -s eth0 wol s sopass 11:22:33:44:55:66
ethtool -s eth0 wol s sopass 22:44:55:66:77:88

Make sure we call into the driver layer set_wol if sopass is different.

Fixes: 55b24334 ("ethtool: ioctl: improve error checking for set_wol")
Signed-off-by: default avatarJustin Chen <justin.chen@broadcom.com>
Link: https://lore.kernel.org/r/1686605822-34544-1-git-send-email-justin.chen@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e5d4a21b

net/ethtool/ioctl.c

+2 −1
Original line number Diff line number Diff line
@@ -1452,7 +1452,8 @@ static int ethtool_set_wol(struct net_device *dev, char __user *useraddr) 
	if (wol.wolopts & ~cur_wol.supported)

		return -EINVAL;



	if (wol.wolopts == cur_wol.wolopts)

	if (wol.wolopts == cur_wol.wolopts &&

	    !memcmp(wol.sopass, cur_wol.sopass, sizeof(wol.sopass)))

		return 0;



	ret = dev->ethtool_ops->set_wol(dev, &wol);