Unverified Commit 2ba776f9 authored by Chen-Yu Tsai's avatar Chen-Yu Tsai Committed by Robert Foss
Browse files

drm/bridge: anx7625: Use common macros for DP power sequencing commands 



The DRM DP code has macros for the DP power sequencing commands. Use
them in the anx7625 driver instead of raw numbers.

Fixes: 548b512e ("drm/bridge: anx7625: send DPCD command to downstream")
Fixes: 27f26359 ("drm/bridge: anx7625: Set downstream sink into normal status")
Signed-off-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarNícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230710090929.1873646-1-wenst@chromium.org
parent 03fad56a

drivers/gpu/drm/bridge/analogix/anx7625.c

+4 −4
Original line number Diff line number Diff line
@@ -931,8 +931,8 @@ static void anx7625_dp_start(struct anx7625_data *ctx) 


	dev_dbg(dev, "set downstream sink into normal\n");

	/* Downstream sink enter into normal mode */

	data = 1;

	ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);

	data = DP_SET_POWER_D0;

	ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, DP_SET_POWER, 1, &data);

	if (ret < 0)

		dev_err(dev, "IO error : set sink into normal mode fail\n");
@@ -971,8 +971,8 @@ static void anx7625_dp_stop(struct anx7625_data *ctx) 


	dev_dbg(dev, "notify downstream enter into standby\n");

	/* Downstream monitor enter into standby mode */

	data = 2;

	ret |= anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);

	data = DP_SET_POWER_D3;

	ret |= anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, DP_SET_POWER, 1, &data);

	if (ret < 0)

		DRM_DEV_ERROR(dev, "IO error : mute video fail\n");