Commit 2ba30662 authored by Jian Shen's avatar Jian Shen Committed by Jakub Kicinski
Browse files

net: hns3: add support for modify VLAN filter state 



Previously, with hardware limitation, the port VLAN filter are
effective for both PF and its VFs simultaneously, so a single
function is not able to enable/disable separately, and the VLAN
filter state is default enabled. Now some device supports each
function to bypass port VLAN filter, then each function can
switch VLAN filter separately. Add capability flag to check
whether the device supports modify VLAN filter state. If flag
on, user will be able to modify the VLAN filter state by ethtool
-K.

Furtherly, the default VLAN filter state is also changed
according to whether non-zero VLAN used. Then the device can
receive packet with any VLAN tag if only VLAN 0 used.

The function hclge_need_enable_vport_vlan_filter() is used to
help implement above changes. And the VLAN filter handle for
promisc mode can also be simplified by this function.

Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 060e9acc

drivers/net/ethernet/hisilicon/hns3/hnae3.h

+3 −2
Original line number Diff line number Diff line
@@ -92,6 +92,8 @@ enum HNAE3_DEV_CAP_BITS { 
	HNAE3_DEV_SUPPORT_UDP_TUNNEL_CSUM_B,

	HNAE3_DEV_SUPPORT_PAUSE_B,

	HNAE3_DEV_SUPPORT_RXD_ADV_LAYOUT_B,

	HNAE3_DEV_SUPPORT_PORT_VLAN_BYPASS_B,

	HNAE3_DEV_SUPPORT_VLAN_FLTR_MDF_B,

};



#define hnae3_dev_fd_supported(hdev) \
@@ -631,7 +633,7 @@ struct hnae3_ae_ops { 
	void (*get_mdix_mode)(struct hnae3_handle *handle,

			      u8 *tp_mdix_ctrl, u8 *tp_mdix);



	void (*enable_vlan_filter)(struct hnae3_handle *handle, bool enable);

	int (*enable_vlan_filter)(struct hnae3_handle *handle, bool enable);

	int (*set_vlan_filter)(struct hnae3_handle *handle, __be16 proto,

			       u16 vlan_id, bool is_kill);

	int (*set_vf_vlan_filter)(struct hnae3_handle *handle, int vfid,
@@ -783,7 +785,6 @@ struct hnae3_roce_private_info { 
#define HNAE3_BPE		BIT(2)	/* broadcast promisc enable */

#define HNAE3_OVERFLOW_UPE	BIT(3)	/* unicast mac vlan overflow */

#define HNAE3_OVERFLOW_MPE	BIT(4)	/* multicast mac vlan overflow */

#define HNAE3_VLAN_FLTR		BIT(5)	/* enable vlan filter */

#define HNAE3_UPE		(HNAE3_USER_UPE | HNAE3_OVERFLOW_UPE)

#define HNAE3_MPE		(HNAE3_USER_MPE | HNAE3_OVERFLOW_MPE)

drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c

+7 −1
Original line number Diff line number Diff line
@@ -345,7 +345,13 @@ static struct hns3_dbg_cap_info hns3_dbg_cap[] = { 
	}, {

		.name = "support rxd advanced layout",

		.cap_bit = HNAE3_DEV_SUPPORT_RXD_ADV_LAYOUT_B,

	},

	}, {

		.name = "support port vlan bypass",

		.cap_bit = HNAE3_DEV_SUPPORT_PORT_VLAN_BYPASS_B,

	}, {

		.name = "support modify vlan filter state",

		.cap_bit = HNAE3_DEV_SUPPORT_VLAN_FLTR_MDF_B,

	}

};



static void hns3_dbg_fill_content(char *content, u16 len,

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+14 −25
Original line number Diff line number Diff line
@@ -908,13 +908,10 @@ static u8 hns3_get_netdev_flags(struct net_device *netdev) 
{

	u8 flags = 0;



	if (netdev->flags & IFF_PROMISC) {

	if (netdev->flags & IFF_PROMISC)

		flags = HNAE3_USER_UPE | HNAE3_USER_MPE | HNAE3_BPE;

	} else {

		flags |= HNAE3_VLAN_FLTR;

		if (netdev->flags & IFF_ALLMULTI)

			flags |= HNAE3_USER_MPE;

	}

	else if (netdev->flags & IFF_ALLMULTI)

		flags = HNAE3_USER_MPE;



	return flags;

}
@@ -944,25 +941,6 @@ void hns3_request_update_promisc_mode(struct hnae3_handle *handle) 
		ops->request_update_promisc_mode(handle);

}



void hns3_enable_vlan_filter(struct net_device *netdev, bool enable)

{

	struct hns3_nic_priv *priv = netdev_priv(netdev);

	struct hnae3_handle *h = priv->ae_handle;

	struct hnae3_ae_dev *ae_dev = pci_get_drvdata(h->pdev);

	bool last_state;



	if (ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2 &&

	    h->ae_algo->ops->enable_vlan_filter) {

		last_state = h->netdev_flags & HNAE3_VLAN_FLTR ? true : false;

		if (enable != last_state) {

			netdev_info(netdev,

				    "%s vlan filter\n",

				    enable ? "enable" : "disable");

			h->ae_algo->ops->enable_vlan_filter(h, enable);

		}

	}

}



static int hns3_set_tso(struct sk_buff *skb, u32 *paylen_fdop_ol4cs,

			u16 *mss, u32 *type_cs_vlan_tso, u32 *send_bytes)

{
@@ -1980,6 +1958,14 @@ static int hns3_nic_set_features(struct net_device *netdev, 
		return -EINVAL;

	}



	if ((changed & NETIF_F_HW_VLAN_CTAG_FILTER) &&

	    h->ae_algo->ops->enable_vlan_filter) {

		enable = !!(features & NETIF_F_HW_VLAN_CTAG_FILTER);

		ret = h->ae_algo->ops->enable_vlan_filter(h, enable);

		if (ret)

			return ret;

	}



	netdev->features = features;

	return 0;

}
@@ -2825,6 +2811,9 @@ static void hns3_set_default_feature(struct net_device *netdev) 
		netdev->hw_features |= NETIF_F_HW_TC;

		netdev->features |= NETIF_F_HW_TC;

	}



	if (test_bit(HNAE3_DEV_SUPPORT_VLAN_FLTR_MDF_B, ae_dev->caps))

		netdev->hw_features |= NETIF_F_HW_VLAN_CTAG_FILTER;

}



static int hns3_alloc_buffer(struct hns3_enet_ring *ring,

drivers/net/ethernet/hisilicon/hns3/hns3_enet.h

+0 −1
Original line number Diff line number Diff line
@@ -643,7 +643,6 @@ void hns3_set_vector_coalesce_rx_ql(struct hns3_enet_tqp_vector *tqp_vector, 
void hns3_set_vector_coalesce_tx_ql(struct hns3_enet_tqp_vector *tqp_vector,

				    u32 ql_value);



void hns3_enable_vlan_filter(struct net_device *netdev, bool enable);

void hns3_request_update_promisc_mode(struct hnae3_handle *handle);



#ifdef CONFIG_HNS3_DCB

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

+2 −6
Original line number Diff line number Diff line
@@ -88,7 +88,6 @@ static int hns3_lp_setup(struct net_device *ndev, enum hnae3_loop loop, bool en) 
{

	struct hnae3_handle *h = hns3_get_handle(ndev);

	struct hnae3_ae_dev *ae_dev = pci_get_drvdata(h->pdev);

	bool vlan_filter_enable;

	int ret;



	if (!h->ae_algo->ops->set_loopback ||
@@ -110,14 +109,11 @@ static int hns3_lp_setup(struct net_device *ndev, enum hnae3_loop loop, bool en) 
	if (ret || ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2)

		return ret;



	if (en) {

	if (en)

		h->ae_algo->ops->set_promisc_mode(h, true, true);

	} else {

	else

		/* recover promisc mode before loopback test */

		hns3_request_update_promisc_mode(h);

		vlan_filter_enable = ndev->flags & IFF_PROMISC ? false : true;

		hns3_enable_vlan_filter(ndev, vlan_filter_enable);

	}



	return ret;

}