Commit 2b85144a authored by Xin Long's avatar Xin Long Committed by David S. Miller
Browse files

openvswitch: return NF_DROP when fails to add nat ext in ovs_ct_nat 



When it fails to allocate nat ext, the packet should be dropped, like
the memory allocation failures in other places in ovs_ct_nat().

This patch changes to return NF_DROP when fails to add nat ext before
doing NAT in ovs_ct_nat(), also it would keep consistent with tc
action ct' processing in tcf_ct_act_nat().

Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarAaron Conole <aconole@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 77959289

net/openvswitch/conntrack.c

+1 −1
Original line number Diff line number Diff line
@@ -821,7 +821,7 @@ static int ovs_ct_nat(struct net *net, struct sw_flow_key *key, 


	/* Add NAT extension if not confirmed yet. */

	if (!nf_ct_is_confirmed(ct) && !nf_ct_nat_ext_add(ct))

		return NF_ACCEPT;   /* Can't NAT. */

		return NF_DROP;   /* Can't NAT. */



	/* Determine NAT type.

	 * Check if the NAT type can be deduced from the tracked connection.