Commit 2b7f1b8c authored by Raphael Assenat's avatar Raphael Assenat Committed by Richard Purdie
Browse files

leds: Fix led-gpio active_low default brightness 



When gpio_direction_output() is called, led_dat->active_low is used
as default value. This means that the led will always be off by
default. cdev.brightness should really have been set to LED_OFF
unconditionally to reflect this behavior.

Signed-off-by: default avatarRaphael Assenat <raph@8d.com>
Signed-off-by: default avatarRichard Purdie <rpurdie@rpsys.net>
parent 92e015cb

drivers/leds/leds-gpio.c

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ static int gpio_led_probe(struct platform_device *pdev) 
		led_dat->can_sleep = gpio_cansleep(cur_led->gpio);

		led_dat->active_low = cur_led->active_low;

		led_dat->cdev.brightness_set = gpio_led_set;

		led_dat->cdev.brightness = cur_led->active_low ? LED_FULL : LED_OFF;

		led_dat->cdev.brightness = LED_OFF;



		ret = gpio_request(led_dat->gpio, led_dat->cdev.name);

		if (ret < 0)