Commit 2b74e2ca authored by Duan Jiong's avatar Duan Jiong Committed by David S. Miller
Browse files

net: em_canid: remove useless statements from em_canid_change 



tcf_ematch is allocated by kzalloc in function tcf_em_tree_validate(),
so cm_old is always NULL.

Signed-off-by: default avatarDuan Jiong <duanj.fnst@cn.fujitsu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a3f5ee71

net/sched/em_canid.c

+0 −7
Original line number Diff line number Diff line
@@ -125,7 +125,6 @@ static int em_canid_change(struct tcf_proto *tp, void *data, int len, 
{

	struct can_filter *conf = data; /* Array with rules */

	struct canid_match *cm;

	struct canid_match *cm_old = (struct canid_match *)m->data;

	int i;



	if (!len)
@@ -181,12 +180,6 @@ static int em_canid_change(struct tcf_proto *tp, void *data, int len, 


	m->datalen = sizeof(struct canid_match) + len;

	m->data = (unsigned long)cm;



	if (cm_old != NULL) {

		pr_err("canid: Configuring an existing ematch!\n");

		kfree(cm_old);

	}



	return 0;

}