Commit 2b71b66a authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

gpio: wcove: Split error handling for CTRL and IRQ registers 



The wcove_gpio_dbg_show() uses one message to all possible error reads.
Split it to two for CTRL and IRQ registers.

While at it, switch to use dev_err() instead of pr_err().

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 5d993664

drivers/gpio/gpio-wcove.c

+7 −3
Original line number Diff line number Diff line
@@ -364,8 +364,7 @@ static irqreturn_t wcove_gpio_irq_handler(int irq, void *data) 
	return IRQ_HANDLED;

}



static void wcove_gpio_dbg_show(struct seq_file *s,

				      struct gpio_chip *chip)

static void wcove_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)

{

	unsigned int ctlo, ctli, irq_mask, irq_status;

	struct wcove_gpio *wg = gpiochip_get_data(chip);
@@ -374,10 +373,15 @@ static void wcove_gpio_dbg_show(struct seq_file *s, 
	for (gpio = 0; gpio < WCOVE_GPIO_NUM; gpio++) {

		ret += regmap_read(wg->regmap, to_reg(gpio, CTRL_OUT), &ctlo);

		ret += regmap_read(wg->regmap, to_reg(gpio, CTRL_IN), &ctli);

		if (ret) {

			dev_err(wg->dev, "Failed to read registers: CTRL out/in\n");

			break;

		}



		ret += regmap_read(wg->regmap, to_ireg(gpio, IRQ_MASK, &mask), &irq_mask);

		ret += regmap_read(wg->regmap, to_ireg(gpio, IRQ_STATUS, &mask), &irq_status);

		if (ret) {

			pr_err("Failed to read registers: ctrl out/in or irq status/mask\n");

			dev_err(wg->dev, "Failed to read registers: IRQ status/mask\n");

			break;

		}