Commit 2b6e5ba3 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Greg Kroah-Hartman
Browse files

misc: ds1682: clean up ds1682_eeprom_read() and ds1682_eeprom_write() 



The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller side in fs/sysfs/file.c

Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent acb921a5

drivers/misc/ds1682.c

+0 −12
Original line number Original line Diff line number Diff line
@@ -148,12 +148,6 @@ static ssize_t ds1682_eeprom_read(struct file *filp, struct kobject *kobj, 
	dev_dbg(&client->dev, "ds1682_eeprom_read(p=%p, off=%lli, c=%zi)\n",

	dev_dbg(&client->dev, "ds1682_eeprom_read(p=%p, off=%lli, c=%zi)\n",

		buf, off, count);

		buf, off, count);





	if (off >= DS1682_EEPROM_SIZE)

		return 0;



	if (off + count > DS1682_EEPROM_SIZE)

		count = DS1682_EEPROM_SIZE - off;



	rc = i2c_smbus_read_i2c_block_data(client, DS1682_REG_EEPROM + off,

	rc = i2c_smbus_read_i2c_block_data(client, DS1682_REG_EEPROM + off,

					   count, buf);

					   count, buf);

	if (rc < 0)

	if (rc < 0)
@@ -171,12 +165,6 @@ static ssize_t ds1682_eeprom_write(struct file *filp, struct kobject *kobj, 
	dev_dbg(&client->dev, "ds1682_eeprom_write(p=%p, off=%lli, c=%zi)\n",

	dev_dbg(&client->dev, "ds1682_eeprom_write(p=%p, off=%lli, c=%zi)\n",

		buf, off, count);

		buf, off, count);





	if (off >= DS1682_EEPROM_SIZE)

		return -ENOSPC;



	if (off + count > DS1682_EEPROM_SIZE)

		count = DS1682_EEPROM_SIZE - off;



	/* Write out to the device */

	/* Write out to the device */

	if (i2c_smbus_write_i2c_block_data(client, DS1682_REG_EEPROM + off,

	if (i2c_smbus_write_i2c_block_data(client, DS1682_REG_EEPROM + off,

					   count, buf) < 0)

					   count, buf) < 0)