Commit 2b2f106e authored by Lucas Stach's avatar Lucas Stach Committed by Shawn Guo
Browse files

Revert "soc: imx: gpcv2: move reset assert after requesting domain power up" 



This reverts commit a77ebdd9f553. It turns out that the VPU domain has no
different requirements, even though the downstream ATF implementation seems
to suggest otherwise. Powering on the domain with the reset asserted works
fine. As the changed sequence has caused sporadic issues with the GPU
domains, just revert the change to go back to the working sequence.

Cc: <stable@vger.kernel.org> # 5.14
Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Acked-by: default avatarPeng Fan <peng.fan@nxp.com>
Tested-by: Adam Ford <aford173@gmail.com> #imx8mm-beacon
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 8da8bd53

drivers/soc/imx/gpcv2.c

+2 −2
Original line number Diff line number Diff line
@@ -244,6 +244,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) 
		goto out_regulator_disable;

	}



	reset_control_assert(domain->reset);



	if (domain->bits.pxx) {

		/* request the domain to power up */

		regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ,
@@ -268,8 +270,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) 
		}

	}



	reset_control_assert(domain->reset);



	/* delay for reset to propagate */

	udelay(5);