Commit 2ae9c66b authored by Wei Fang's avatar Wei Fang Committed by David S. Miller
Browse files

net: fec: remove useless fec_enet_reset_skb() 



This patch is a cleanup for fec driver. The fec_enet_reset_skb()
is used to free skb buffers for tx queues and is only invoked in
fec_restart(). However, fec_enet_bd_init() also resets skb buffers
and is invoked in fec_restart() too. So fec_enet_reset_skb() is
redundant and useless.

Signed-off-by: default avatarWei Fang <wei.fang@nxp.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e4ac7cc6

drivers/net/ethernet/freescale/fec_main.c

+0 −21
Original line number Diff line number Diff line
@@ -1011,24 +1011,6 @@ static void fec_enet_enable_ring(struct net_device *ndev) 
	}

}



static void fec_enet_reset_skb(struct net_device *ndev)

{

	struct fec_enet_private *fep = netdev_priv(ndev);

	struct fec_enet_priv_tx_q *txq;

	int i, j;



	for (i = 0; i < fep->num_tx_queues; i++) {

		txq = fep->tx_queue[i];



		for (j = 0; j < txq->bd.ring_size; j++) {

			if (txq->tx_skbuff[j]) {

				dev_kfree_skb_any(txq->tx_skbuff[j]);

				txq->tx_skbuff[j] = NULL;

			}

		}

	}

}



/*

 * This function is called to start or restart the FEC during a link

 * change, transmit timeout, or to reconfigure the FEC.  The network
@@ -1071,9 +1053,6 @@ fec_restart(struct net_device *ndev) 


	fec_enet_enable_ring(ndev);



	/* Reset tx SKB buffers. */

	fec_enet_reset_skb(ndev);



	/* Enable MII mode */

	if (fep->full_duplex == DUPLEX_FULL) {

		/* FD enable */