Commit 2a8e41ad authored by Chris Packham's avatar Chris Packham Committed by Guenter Roeck
Browse files

hwmon: (adt7475) Use device_property APIs when configuring polarity 



On DT unaware platforms of_property_read_u32_array() returns -ENOSYS
which wasn't handled by the code treating adi,pwm-active-state as
optional. Update the code to use device_property_read_u32_array() which
deals gracefully with DT unaware platforms.

Fixes: 86da28ee ("hwmon: (adt7475) Add support for inverting pwm output")
Reported-by: default avatarMariusz Białończyk <manio@skyboo.net>
Link: https://lore.kernel.org/linux-hwmon/52e26a67-9131-2dc0-40cb-db5c07370027@alliedtelesis.co.nz/T/#mdd0505801e0a4e72340de009a47c0fca4f771ed3


Signed-off-by: default avatarChris Packham <chris.packham@alliedtelesis.co.nz>
Link: https://lore.kernel.org/r/20230418233656.869055-2-chris.packham@alliedtelesis.co.nz


Cc: stable@vger.kernel.org
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 19692f17

drivers/hwmon/adt7475.c

+3 −3
Original line number Diff line number Diff line
@@ -1604,7 +1604,7 @@ static int adt7475_set_pwm_polarity(struct i2c_client *client) 
	int ret, i;

	u8 val;



	ret = of_property_read_u32_array(client->dev.of_node,

	ret = device_property_read_u32_array(&client->dev,

					     "adi,pwm-active-state", states,

					     ARRAY_SIZE(states));

	if (ret)