Commit 2a829fe2 authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: TC, Clean redundant counter flag from tc action parsers 



When tc actions being parsed only the last flow attr created needs the
counter flag and the previous flags being reset.
Clean the flag from the tc action parsers.

Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent a8128326

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/accept.c

+1 −2
Original line number Diff line number Diff line
@@ -19,8 +19,7 @@ tc_act_parse_accept(struct mlx5e_tc_act_parse_state *parse_state, 
		    struct mlx5e_priv *priv,

		    struct mlx5_flow_attr *attr)

{

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |

			MLX5_FLOW_CONTEXT_ACTION_COUNT;

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;

	attr->flags |= MLX5_ATTR_FLAG_ACCEPT;



	return 0;

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/drop.c

+1 −2
Original line number Diff line number Diff line
@@ -19,8 +19,7 @@ tc_act_parse_drop(struct mlx5e_tc_act_parse_state *parse_state, 
		  struct mlx5e_priv *priv,

		  struct mlx5_flow_attr *attr)

{

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP |

			MLX5_FLOW_CONTEXT_ACTION_COUNT;

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP;



	return 0;

}

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/goto.c

+1 −2
Original line number Diff line number Diff line
@@ -76,8 +76,7 @@ tc_act_parse_goto(struct mlx5e_tc_act_parse_state *parse_state, 
		  struct mlx5e_priv *priv,

		  struct mlx5_flow_attr *attr)

{

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |

			MLX5_FLOW_CONTEXT_ACTION_COUNT;

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;

	attr->dest_chain = act->chain_index;



	return 0;

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred.c

+1 −2
Original line number Diff line number Diff line
@@ -296,8 +296,7 @@ tc_act_parse_mirred(struct mlx5e_tc_act_parse_state *parse_state, 
	if (err)

		return err;



	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |

			MLX5_FLOW_CONTEXT_ACTION_COUNT;

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;



	return 0;

}

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/mirred_nic.c

+1 −2
Original line number Diff line number Diff line
@@ -40,8 +40,7 @@ tc_act_parse_mirred_nic(struct mlx5e_tc_act_parse_state *parse_state, 
{

	attr->parse_attr->mirred_ifindex[0] = act->dev->ifindex;

	flow_flag_set(parse_state->flow, HAIRPIN);

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |

			MLX5_FLOW_CONTEXT_ACTION_COUNT;

	attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;



	return 0;

}