Commit 2a7d6b9c authored by Vaishnav Achath's avatar Vaishnav Achath Committed by Mauro Carvalho Chehab
Browse files

media: v4l2-mc: Drop subdev check in v4l2_create_fwnode_links_to_pad() 



While updating v4l2_create_fwnode_links_to_pad() to accept non-subdev
sinks, the check is_media_entity_v4l2_subdev() was not removed which
prevented the function from being used with non-subdev sinks, Drop the
unnecessary check.

Fixes: bd5a03bc ("media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad()")
Signed-off-by: default avatarVaishnav Achath <vaishnav.a@ti.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 11aaa0ec

drivers/media/v4l2-core/v4l2-mc.c

+1 −2
Original line number Diff line number Diff line
@@ -326,8 +326,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, 
{

	struct fwnode_handle *endpoint;



	if (!(sink->flags & MEDIA_PAD_FL_SINK) ||

	    !is_media_entity_v4l2_subdev(sink->entity))

	if (!(sink->flags & MEDIA_PAD_FL_SINK))

		return -EINVAL;



	fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) {