Commit 2a4a910a authored May 25, 2021 by Hannes Reinecke Committed by Christoph Hellwig Jun 17, 2021

nvmet-fc: do not check for invalid target port in nvmet_fc_handle_fcp_rqst()



When parsing a request in nvmet_fc_handle_fcp_rqst() we should not
check for invalid target ports; if we do the command is aborted
from the fcp layer, causing the host to assume a transport error.
Rather we should still forward this request to the nvmet layer, which
will then correctly fail the command with an appropriate error status.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent eff4423e

drivers/nvme/target/fc.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -2510,13 +2510,6 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport,
		u32 xfrlen = be32_to_cpu(cmdiu->data_len);
		int ret;

		/*
		* if there is no nvmet mapping to the targetport there
		* shouldn't be requests. just terminate them.
		*/
		if (!tgtport->pe)
		goto transport_error;

		/*
		* Fused commands are currently not supported in the linux
		* implementation.
		@@ -2544,6 +2537,7 @@ nvmet_fc_handle_fcp_rqst(struct nvmet_fc_tgtport *tgtport,

		fod->req.cmd = &fod->cmdiubuf.sqe;
		fod->req.cqe = &fod->rspiubuf.cqe;
		if (tgtport->pe)
		fod->req.port = tgtport->pe->port;

		/* clear any response payload */