Commit 2a455745 authored by NeilBrown's avatar NeilBrown Committed by Chuck Lever
Browse files

SUNRPC: Remove return value of svc_pool_wake_idle_thread() 



The returned value is not used (any more), so don't return it.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 6859d1f2

include/linux/sunrpc/svc.h

+1 −1
Original line number Diff line number Diff line
@@ -420,7 +420,7 @@ int svc_register(const struct svc_serv *, struct net *, const int, 


void		   svc_wake_up(struct svc_serv *);

void		   svc_reserve(struct svc_rqst *rqstp, int space);

bool		   svc_pool_wake_idle_thread(struct svc_pool *pool);

void		   svc_pool_wake_idle_thread(struct svc_pool *pool);

struct svc_pool   *svc_pool_for_cpu(struct svc_serv *serv);

char *		   svc_print_addr(struct svc_rqst *, char *, size_t);

const char *	   svc_proc_name(const struct svc_rqst *rqstp);

net/sunrpc/svc.c

+2 −6
Original line number Diff line number Diff line
@@ -697,11 +697,8 @@ svc_prepare_thread(struct svc_serv *serv, struct svc_pool *pool, int node) 
 * service thread and marking it BUSY is atomic with respect to

 * other calls to svc_pool_wake_idle_thread().

 *

 * Return value:

 *   %true: An idle thread was awoken

 *   %false: No idle thread was found

 */

bool svc_pool_wake_idle_thread(struct svc_pool *pool)

void svc_pool_wake_idle_thread(struct svc_pool *pool)

{

	struct svc_rqst	*rqstp;
@@ -715,12 +712,11 @@ bool svc_pool_wake_idle_thread(struct svc_pool *pool) 
		rcu_read_unlock();

		percpu_counter_inc(&pool->sp_threads_woken);

		trace_svc_wake_up(rqstp->rq_task->pid);

		return true;

		return;

	}

	rcu_read_unlock();



	set_bit(SP_CONGESTED, &pool->sp_flags);

	return false;

}



static struct svc_pool *