Commit 2a441a3d authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Jakub Kicinski
Browse files

net: txgbe: remove unused buffer in txgbe_calc_eeprom_checksum 



Half a year passed since commit 049fe536 ("net: txgbe: Add operations
to interact with firmware") was submitted, the buffer in
txgbe_calc_eeprom_checksum was not used. So remove it and the related
branch codes.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306200242.FXsHokaJ-lkp@intel.com/


Reviewed-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230620062519.1575298-1-shaozhengchao@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 018c00dd

drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c

+11 −21
Original line number Diff line number Diff line
@@ -160,34 +160,24 @@ int txgbe_read_pba_string(struct wx *wx, u8 *pba_num, u32 pba_num_size) 
static int txgbe_calc_eeprom_checksum(struct wx *wx, u16 *checksum)

{

	u16 *eeprom_ptrs = NULL;

	u32 buffer_size = 0;

	u16 *buffer = NULL;

	u16 *local_buffer;

	int status;

	u16 i;



	wx_init_eeprom_params(wx);



	if (!buffer) {

	eeprom_ptrs = kvmalloc_array(TXGBE_EEPROM_LAST_WORD, sizeof(u16),

				     GFP_KERNEL);

	if (!eeprom_ptrs)

		return -ENOMEM;

	/* Read pointer area */

		status = wx_read_ee_hostif_buffer(wx, 0,

						  TXGBE_EEPROM_LAST_WORD,

						  eeprom_ptrs);

	status = wx_read_ee_hostif_buffer(wx, 0, TXGBE_EEPROM_LAST_WORD, eeprom_ptrs);

	if (status != 0) {

		wx_err(wx, "Failed to read EEPROM image\n");

		kvfree(eeprom_ptrs);

		return status;

	}

	local_buffer = eeprom_ptrs;

	} else {

		if (buffer_size < TXGBE_EEPROM_LAST_WORD)

			return -EFAULT;

		local_buffer = buffer;

	}



	for (i = 0; i < TXGBE_EEPROM_LAST_WORD; i++)

		if (i != wx->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM)