Commit 2a36ed7c authored by Tom Rix's avatar Tom Rix Committed by David S. Miller
Browse files

dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key 



Clang static analysis reports this representative problem
dpaa2-switch-flower.c:616:24: warning: The right operand of '=='
  is a garbage value
  tmp->cfg.vlan_id == vlan) {
                   ^  ~~~~
vlan is set in dpaa2_switch_flower_parse_mirror_key(). However
this function can return success without setting vlan.  So
change the default return to -EOPNOTSUPP.

Fixes: 0f3faece ("dpaa2-switch: add VLAN based mirroring")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarIoana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9d2d38c3

drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c

+3 −1
Original line number Diff line number Diff line
@@ -532,6 +532,7 @@ static int dpaa2_switch_flower_parse_mirror_key(struct flow_cls_offload *cls, 
	struct flow_rule *rule = flow_cls_offload_flow_rule(cls);

	struct flow_dissector *dissector = rule->match.dissector;

	struct netlink_ext_ack *extack = cls->common.extack;

	int ret = -EOPNOTSUPP;



	if (dissector->used_keys &

	    ~(BIT(FLOW_DISSECTOR_KEY_BASIC) |
@@ -561,9 +562,10 @@ static int dpaa2_switch_flower_parse_mirror_key(struct flow_cls_offload *cls, 
		}



		*vlan = (u16)match.key->vlan_id;

		ret = 0;

	}



	return 0;

	return ret;

}



static int