Commit 2a33ad4a authored by Basavaraj Natikar's avatar Basavaraj Natikar Committed by Jiri Kosina
Browse files

HID: amd_sfh: Fix warning unwind goto 



Return directly instead of using existing goto will not cleanup
previously allocated resources. Hence replace return with goto
to fix warning unwind goto which cleanups previously allocated
resources.

Fixes: 93ce5e02 ("HID: amd_sfh: Implement SFH1.1 functionality")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent b3d40c3e

drivers/hid/amd-sfh-hid/amd_sfh_client.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ int amd_sfh_hid_client_init(struct amd_mp2_dev *privdata) 
		}

		rc = mp2_ops->get_rep_desc(cl_idx, cl_data->report_descr[i]);

		if (rc)

			return rc;

			goto cleanup;

		mp2_ops->start(privdata, info);

		status = amd_sfh_wait_for_response

				(privdata, cl_data->sensor_idx[i], SENSOR_ENABLED);

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

+1 −1
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata) 
		}

		rc = mp2_ops->get_rep_desc(cl_idx, cl_data->report_descr[i]);

		if (rc)

			return rc;

			goto cleanup;



		writel(0, privdata->mmio + AMD_P2C_MSG(0));

		mp2_ops->start(privdata, info);