Commit 2a0a8d87 authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Matthias Brugger
Browse files

soc: mediatek: mtk-mmsys: Split out MT8173 mmsys DDP routing table 



MT2701, MT2712 and MT8173 were relying on a "default" DDP I/O routing
table, describing all of the possible connections between display block
components: while this is definitely working it's suboptimal for the
actual routing description, as we may be enabling outputs and inputs
that are not needed, possibly impacting on actual DDP performance other
than slightly prolonging boot times by having to parse a table that is
bigger than needed.

Seen that all of the other supported SoCs have got their own table and
seen that a comment in mtk-mmsys.h explicitly mentions that the wanted
way is to have one table per SoC, create a new routing table that is
specifically tailored to MT8173 and, while at it, remove mentions to
said SoC from the comment in mtk-mmsys.h.

Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230309102618.114157-2-angelogioacchino.delregno@collabora.com


Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent b34884b4

drivers/soc/mediatek/mt8173-mmsys.h

0 → 100644
+95 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0-only */



#ifndef __SOC_MEDIATEK_MT8173_MMSYS_H

#define __SOC_MEDIATEK_MT8173_MMSYS_H



#define MT8173_DISP_REG_CONFIG_DISP_OVL0_MOUT_EN	0x040

#define MT8173_DISP_REG_CONFIG_DISP_OVL1_MOUT_EN	0x044

#define MT8173_DISP_REG_CONFIG_DISP_OD_MOUT_EN		0x048

#define MT8173_DISP_REG_CONFIG_DISP_GAMMA_MOUT_EN	0x04c

#define MT8173_DISP_REG_CONFIG_DISP_UFOE_MOUT_EN	0x050

#define MT8173_DISP_REG_CONFIG_DISP_COLOR0_SEL_IN	0x084

#define MT8173_DISP_REG_CONFIG_DISP_COLOR1_SEL_IN	0x088

#define MT8173_DISP_REG_CONFIG_DISP_AAL_SEL_IN		0x08c

#define MT8173_DISP_REG_CONFIG_DISP_UFOE_SEL_IN		0x0a0

#define MT8173_DISP_REG_CONFIG_DSI0_SEL_IN		0x0a4

#define MT8173_DISP_REG_CONFIG_DPI_SEL_IN		0x0ac

#define MT8173_DISP_REG_CONFIG_DISP_RDMA0_SOUT_SEL_IN	0x0b0

#define MT8173_DISP_REG_CONFIG_DISP_RDMA1_SOUT_EN	0x0c8

#define MT8173_DISP_REG_CONFIG_DISP_COLOR0_SOUT_SEL_IN	0x0bc



#define MT8173_AAL_SEL_IN_MERGE				BIT(0)

#define MT8173_COLOR0_SEL_IN_OVL0			BIT(0)

#define MT8173_COLOR0_SOUT_MERGE			BIT(0)

#define MT8173_DPI0_SEL_IN_MASK				GENMASK(1, 0)

#define MT8173_DPI0_SEL_IN_RDMA1			BIT(0)

#define MT8173_DSI0_SEL_IN_UFOE				BIT(0)

#define MT8173_GAMMA_MOUT_EN_RDMA1			BIT(0)

#define MT8173_OD0_MOUT_EN_RDMA0			BIT(0)

#define MT8173_OVL0_MOUT_EN_COLOR0			BIT(0)

#define MT8173_OVL1_MOUT_EN_COLOR1			BIT(0)

#define MT8173_UFOE_MOUT_EN_DSI0			BIT(0)

#define MT8173_UFOE_SEL_IN_RDMA0			BIT(0)

#define MT8173_RDMA0_SOUT_COLOR0			BIT(0)



static const struct mtk_mmsys_routes mt8173_mmsys_routing_table[] = {

	{

		DDP_COMPONENT_OVL0, DDP_COMPONENT_COLOR0,

		MT8173_DISP_REG_CONFIG_DISP_OVL0_MOUT_EN,

		MT8173_OVL0_MOUT_EN_COLOR0, MT8173_OVL0_MOUT_EN_COLOR0

	}, {

		DDP_COMPONENT_OD0, DDP_COMPONENT_RDMA0,

		MT8173_DISP_REG_CONFIG_DISP_OD_MOUT_EN,

		MT8173_OD0_MOUT_EN_RDMA0, MT8173_OD0_MOUT_EN_RDMA0

	}, {

		DDP_COMPONENT_UFOE, DDP_COMPONENT_DSI0,

		MT8173_DISP_REG_CONFIG_DISP_UFOE_MOUT_EN,

		MT8173_UFOE_MOUT_EN_DSI0, MT8173_UFOE_MOUT_EN_DSI0

	}, {

		DDP_COMPONENT_COLOR0, DDP_COMPONENT_AAL0,

		MT8173_DISP_REG_CONFIG_DISP_COLOR0_SOUT_SEL_IN,

		MT8173_COLOR0_SOUT_MERGE, 0 /* SOUT to AAL */

	}, {

		DDP_COMPONENT_RDMA0, DDP_COMPONENT_UFOE,

		MT8173_DISP_REG_CONFIG_DISP_RDMA0_SOUT_SEL_IN,

		MT8173_RDMA0_SOUT_COLOR0, 0 /* SOUT to UFOE */

	}, {

		DDP_COMPONENT_OVL0, DDP_COMPONENT_COLOR0,

		MT8173_DISP_REG_CONFIG_DISP_COLOR0_SEL_IN,

		MT8173_COLOR0_SEL_IN_OVL0, MT8173_COLOR0_SEL_IN_OVL0

	}, {

		DDP_COMPONENT_AAL0, DDP_COMPONENT_COLOR0,

		MT8173_DISP_REG_CONFIG_DISP_AAL_SEL_IN,

		MT8173_AAL_SEL_IN_MERGE, 0 /* SEL_IN from COLOR0 */

	}, {

		DDP_COMPONENT_RDMA0, DDP_COMPONENT_UFOE,

		MT8173_DISP_REG_CONFIG_DISP_UFOE_SEL_IN,

		MT8173_UFOE_SEL_IN_RDMA0, 0 /* SEL_IN from RDMA0 */

	}, {

		DDP_COMPONENT_UFOE, DDP_COMPONENT_DSI0,

		MT8173_DISP_REG_CONFIG_DSI0_SEL_IN,

		MT8173_DSI0_SEL_IN_UFOE, 0, /* SEL_IN from UFOE */

	}, {

		DDP_COMPONENT_OVL1, DDP_COMPONENT_COLOR1,

		MT8173_DISP_REG_CONFIG_DISP_OVL1_MOUT_EN,

		MT8173_OVL1_MOUT_EN_COLOR1, MT8173_OVL1_MOUT_EN_COLOR1

	}, {

		DDP_COMPONENT_GAMMA, DDP_COMPONENT_RDMA1,

		MT8173_DISP_REG_CONFIG_DISP_GAMMA_MOUT_EN,

		MT8173_GAMMA_MOUT_EN_RDMA1, MT8173_GAMMA_MOUT_EN_RDMA1

	}, {

		DDP_COMPONENT_RDMA1, DDP_COMPONENT_DPI0,

		MT8173_DISP_REG_CONFIG_DISP_RDMA1_SOUT_EN,

		RDMA1_SOUT_MASK, RDMA1_SOUT_DPI0

	}, {

		DDP_COMPONENT_OVL1, DDP_COMPONENT_COLOR1,

		MT8173_DISP_REG_CONFIG_DISP_COLOR1_SEL_IN,

		COLOR1_SEL_IN_OVL1, COLOR1_SEL_IN_OVL1

	}, {

		DDP_COMPONENT_RDMA1, DDP_COMPONENT_DPI0,

		MT8173_DISP_REG_CONFIG_DPI_SEL_IN,

		MT8173_DPI0_SEL_IN_MASK, MT8173_DPI0_SEL_IN_RDMA1

	}

};



#endif /* __SOC_MEDIATEK_MT8173_MMSYS_H */

drivers/soc/mediatek/mtk-mmsys.c

+3 −2
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 


#include "mtk-mmsys.h"

#include "mt8167-mmsys.h"

#include "mt8173-mmsys.h"

#include "mt8183-mmsys.h"

#include "mt8186-mmsys.h"

#include "mt8188-mmsys.h"
@@ -52,8 +53,8 @@ static const struct mtk_mmsys_driver_data mt8167_mmsys_driver_data = { 


static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = {

	.clk_driver = "clk-mt8173-mm",

	.routes = mmsys_default_routing_table,

	.num_routes = ARRAY_SIZE(mmsys_default_routing_table),

	.routes = mt8173_mmsys_routing_table,

	.num_routes = ARRAY_SIZE(mt8173_mmsys_routing_table),

	.sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,

	.num_resets = 32,

};

drivers/soc/mediatek/mtk-mmsys.h

+1 −1
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ struct mtk_mmsys_driver_data { 
};



/*

 * Routes in mt8173, mt2701, mt2712 are different. That means

 * Routes in mt2701 and mt2712 are different. That means

 * in the same register address, it controls different input/output

 * selection for each SoC. But, right now, they use the same table as

 * default routes meet their requirements. But we don't have the complete