Commit 29eb3154 authored by Hangyu Hua's avatar Hangyu Hua Committed by David S. Miller
Browse files

yam: fix a memory leak in yam_siocdevprivate() 



ym needs to be free when ym->cmd != SIOCYAMSMCS.

Fixes: 0781168e ("yam: fix a missing-check bug")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c74ead22

drivers/net/hamradio/yam.c

+1 −3
Original line number Diff line number Diff line
@@ -950,9 +950,7 @@ static int yam_siocdevprivate(struct net_device *dev, struct ifreq *ifr, void __ 
		ym = memdup_user(data, sizeof(struct yamdrv_ioctl_mcs));

		if (IS_ERR(ym))

			return PTR_ERR(ym);

		if (ym->cmd != SIOCYAMSMCS)

			return -EINVAL;

		if (ym->bitrate > YAM_MAXBITRATE) {

		if (ym->cmd != SIOCYAMSMCS || ym->bitrate > YAM_MAXBITRATE) {

			kfree(ym);

			return -EINVAL;

		}