Commit 299c776c authored by Michel Dänzer's avatar Michel Dänzer Committed by Alex Deucher
Browse files

amdgpu: Don't use DRM_ERROR when failing to allocate a BO 



This can be triggered by userspace, e.g. trying to allocate too large a
BO, so it shouldn't log anything by default.

Callers need to handle failure anyway.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarMichel Dänzer <michel.daenzer@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 424e2c85

drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

+1 −1
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ int amdgpu_gem_object_create(struct amdgpu_device *adev, unsigned long size, 
				initial_domain |= AMDGPU_GEM_DOMAIN_GTT;

				goto retry;

			}

			DRM_ERROR("Failed to allocate GEM object (%ld, %d, %u, %d)\n",

			DRM_DEBUG("Failed to allocate GEM object (%ld, %d, %u, %d)\n",

				  size, initial_domain, alignment, r);

		}

		return r;

drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

+2 −2
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ static bool amdgpu_bo_validate_size(struct amdgpu_device *adev, 
	return true;



fail:

	DRM_ERROR("BO size %lu > total memory in domain: %llu\n", size,

	DRM_DEBUG("BO size %lu > total memory in domain: %llu\n", size,

		  man->size << PAGE_SHIFT);

	return false;

}