Commit 29958ab7 authored by Paul Cercueil's avatar Paul Cercueil Committed by Wim Van Sebroeck
Browse files

watchdog: st_lpc_wdt: Remove #ifdef guards for PM related functions 



Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to
handle the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use #ifdef guards. Not using #ifdef guards means that the code is
always compiled independently of any Kconfig option, and thanks to that
bugs and regressions are easier to catch.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220628193449.160585-7-paul@crapouillou.net


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 5c040ea2

drivers/watchdog/st_lpc_wdt.c

+3 −6
Original line number Diff line number Diff line
@@ -248,7 +248,6 @@ static int st_wdog_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int st_wdog_suspend(struct device *dev)

{

	struct st_wdog *st_wdog = watchdog_get_drvdata(&st_wdog_dev);
@@ -285,16 +284,14 @@ static int st_wdog_resume(struct device *dev) 


	return 0;

}

#endif



static SIMPLE_DEV_PM_OPS(st_wdog_pm_ops,

			 st_wdog_suspend,

			 st_wdog_resume);

static DEFINE_SIMPLE_DEV_PM_OPS(st_wdog_pm_ops,

				st_wdog_suspend, st_wdog_resume);



static struct platform_driver st_wdog_driver = {

	.driver	= {

		.name = "st-lpc-wdt",

		.pm = &st_wdog_pm_ops,

		.pm = pm_sleep_ptr(&st_wdog_pm_ops),

		.of_match_table = st_wdog_match,

	},

	.probe = st_wdog_probe,