Commit 2982c953 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kbuild: remove redundant $(wildcard ...) for cmd_files calculation 



I do not see any reason why $(wildcard ...) needs to be called twice
for computing cmd_files.  Remove the first one.

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent 9a234a2e

Makefile

+1 −2
Original line number Diff line number Diff line
@@ -1693,8 +1693,7 @@ cmd_crmodverdir = $(Q)mkdir -p $(MODVERDIR) \ 


# read all saved command lines



targets := $(wildcard $(sort $(targets)))

cmd_files := $(wildcard .*.cmd $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd))

cmd_files := $(wildcard .*.cmd $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))



ifneq ($(cmd_files),)

  $(cmd_files): ;	# Do not try to update included dependency files

scripts/Makefile.build

+1 −2
Original line number Diff line number Diff line
@@ -583,8 +583,7 @@ FORCE: 
# optimization, we don't need to read them if the target does not

# exist, we will rebuild anyway in that case.



targets := $(wildcard $(sort $(targets)))

cmd_files := $(wildcard $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd))

cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))



ifneq ($(cmd_files),)

  include $(cmd_files)

scripts/Makefile.headersinst

+1 −2
Original line number Diff line number Diff line
@@ -114,9 +114,8 @@ $(check-file): scripts/headers_check.pl $(output-files) FORCE 


endif



targets := $(wildcard $(sort $(targets)))

cmd_files := $(wildcard \

             $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd))

             $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))



ifneq ($(cmd_files),)

	include $(cmd_files)

scripts/Makefile.modpost

+1 −2
Original line number Diff line number Diff line
@@ -143,8 +143,7 @@ FORCE: 
# optimization, we don't need to read them if the target does not

# exist, we will rebuild anyway in that case.



targets := $(wildcard $(sort $(targets)))

cmd_files := $(wildcard $(foreach f,$(targets),$(dir $(f)).$(notdir $(f)).cmd))

cmd_files := $(wildcard $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))



ifneq ($(cmd_files),)

  include $(cmd_files)